[Unitary-Hack] Lint rule: Use functions #1579
Conversation
Manvi-Agrawal
changed the title
Manvi-Agrawal
requested review from
idavis,
swernli,
cesarzc,
DmitryVasilevsky,
sezna,
tcNickolas,
billti and
ScottCarda-MS
as code owners
|
Thanks @Manvi-Agrawal ! Would you mind resolving the conflicts in the branch so I can kick off the checks for this PR? I'll give your questions some more thought once I get the feedback from the unit tests in the CI. |
Done @minestarks. I was on it, and when I came back I saw your comment :-). Also, could we please connect over discord, I have few questions about other open issues xD |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This reverts commit b0b42ff.
Co-authored-by: orpuente-MS <[email protected]>
Co-authored-by: orpuente-MS <[email protected]>
Nice catch @minestarks. I realized now that these were originating from unimplemented quick-fix. I had it as TODO, and converting it to no-op(similar to |
|
Hi @minestarks , @orpuente-MS , I have addressed all review comments. Could you please take a look? |
Thanks a ton @orpuente-MS for your review and approval. |
|
Hi @minestarks , do you have any other feedback for this PR. Rust panic was really good edge case. Your todays feedback would give me more bandwidth since I can work over that over the weekend, because hack ends on June 12 |
Co-authored-by: Mine Starks <[email protected]>
Co-authored-by: Mine Starks <[email protected]>
|
Just needs one more signoff from @DmitryVasilevsky, @cesarzc, @sezna, @swernli, @tcNickolas (probably due to the small sample update) . |
Fixes #1471.
Future TODO
NeedlessOperationlint #1593Based on https://github.com/microsoft/qsharp/blob/main/compiler/qsc_passes/src/callable_limits.rs
Note to reviewers
Main changes are in
qsc_linterfolder. Changes in other tests are due to this lint rule complaining about NeedlessOperation, so I converted to function and it changes span accordingly.